project-real-resurrection-3/rr3-ota
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix critical version code formula bug

Browse Source 
Changed formula from (major*100000 + minor*1000 + patch) to the correct
(major*10000 + minor*100 + patch) to match UpdateManager.smali implementation.

Updated all examples:
- 14.5.0 = 140500 (0x224D4) not 145000
- Corrected hex values throughout documentation

This bug would have prevented OTA updates from working correctly.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
ssfdre38
2026-02-24 22:32:41 -08:00
parent b9191a0e86
commit 0daa89e935
2 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
INTEGRATION-GUIDE.md
View File

@@ -101,18 +101,18 @@ Edit `smali/com/community/UpdateManager.smali`:
```smali ```smali
.field private static final CURRENT_VERSION:Ljava/lang/String; = "14.5.0" # Your version .field private static final CURRENT_VERSION:Ljava/lang/String; = "14.5.0" # Your version
.field private static final CURRENT_VERSION_CODE:I = 0x23AB8 # 145000 in hex .field private static final CURRENT_VERSION_CODE:I = 0x224D4 # 140500 in hex
``` ```
**Calculate version code:** **Calculate version code:**
``` ```
versionCode = (major * 100000) + (minor * 1000) + patch versionCode = (major * 10000) + (minor * 100) + patch
Examples: Examples:
14.5.0 → 145000 → 0x23AB8 (hex) 14.5.0 → 140500 → 0x224D4 (hex)
15.0.0 → 150000 → 0x249F0 (hex) 15.0.0 → 150000 → 0x249F0 (hex)
# Convert to hex: printf '%x\n' 145000 # Convert to hex: printf '%x\n' 140500
``` ```
#### Update Manifest URL #### Update Manifest URL
@@ -350,12 +350,12 @@ curl https://raw.githubusercontent.com/YOUR-ORG/YOUR-REPO/main/versions.json
**Fix:** **Fix:**
```bash ```bash
# Calculate version code # Calculate version code
echo "scale=0; (14*100000) + (5*1000) + 0" | bc echo "scale=0; (14*10000) + (5*100) + 0" | bc
# Result: 145000 # Result: 140500
# Convert to hex # Convert to hex
printf '%x\n' 145000 printf '%x\n' 140500
# Result: 23ab8 # Result: 224d4
# Update in smali: # Update in smali:
.field private static final CURRENT_VERSION_CODE:I = 0x23ab8 .field private static final CURRENT_VERSION_CODE:I = 0x23ab8
@@ -451,7 +451,7 @@ gh repo create YOUR-ORG/rr3-releases --public
"versions": [ "versions": [
{ {
"version": "14.5.0", "version": "14.5.0",
"version_code": 145000, "version_code": 140500,
"channel": "stable", "channel": "stable",
"release_date": "2026-02-24", "release_date": "2026-02-24",
"min_android": 21, "min_android": 21,

2
README.md
View File

@@ -115,7 +115,7 @@ private static final int CURRENT_VERSION_CODE = 150000;
**Version Code Formula:** **Version Code Formula:**
``` ```
versionCode = (major * 100000) + (minor * 1000) + patch versionCode = (major * 10000) + (minor * 100) + patch
Examples: Examples:
15.0.0 → 150000 15.0.0 → 150000